tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47216] Possible NPE in Http11Processor.action()
Date Tue, 19 May 2009 12:01:52 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47216





--- Comment #2 from Sebb <sebb@apache.org>  2009-05-19 05:01:51 PST ---
(In reply to comment #1)
> This "bug" is purely theoretical.  The only way to hit it is to hold a
> reference to the Request after request processing has finished.

In that case, why does the action() method bother checking for socket!=null
everywhere else?

It does not make sense to have to check for null when processing
ACTION_REQ_LOCAL_NAME_ATTRIBUTE (e.g.) but not when processing
ACTION_REQ_LOCAL_ADDR_ATTRIBUTE.

> If you do
> that, IMHO you deserve all the NPEs you get.
> +0 to making parseHost protected (since anyone subclassing this will likely
> need it).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message