tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46985] Impossible condition in coyote.http11.Http11Processor.process(Socket socket)
Date Tue, 19 May 2009 00:26:26 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46985





--- Comment #5 from Konstantin Kolinko <knst.kolinko@gmail.com>  2009-05-18 17:26:26
PST ---
(In reply to comment #4)
> 
> I don't see either being set to null.
> 

    public void process(Socket socket)
        throws IOException {
(..)
        // Setting up the I/O
        this.socket = socket;
        inputBuffer.setInputStream(socket.getInputStream());
        outputBuffer.setOutputStream(socket.getOutputStream());

(.....)

        // Recycle
        inputBuffer.recycle();
        outputBuffer.recycle();
        this.socket = null;
        // Recycle ssl info
        sslSupport = null;
    }

I slightly wonder why there is no try/finally...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message