tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47061] JDBCStore for saving sessions doesn't support datasource
Date Mon, 11 May 2009 09:57:38 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47061





--- Comment #5 from Steve Pugh <britsp@bristol.gov.uk>  2009-05-11 02:57:37 PST ---

The patch does indeed move the remove() method. This is because in the original
code, the call to remove() is inside the block of code in save(), which gets
the connection. But the remove() method then gets the connection again! This
isn't such a problem for the "direct connection" method as the connection is
left open after remove() has finished with it. But in the case where the
datasource is being used, the remove() method returns the connection, and then
the connection is then not available to the rest of the save() method.

As you mentioned, maybe this is a separate issue, so I have posted this a
separate patch (patch 1), so that if you decide to treat it separately it will
be easier to do so.

The other patch (patch 2) adds in the code required for datasource support
using JNDI lookup as before. I have also made the new member variables private
as suggested. This patch needs to be applied after patch 1.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message