tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 47124] Run the unit tests as part of the build!!!
Date Tue, 05 May 2009 10:37:24 GMT

--- Comment #4 from Marc Guillemot <>  2009-05-05 03:37:21 PST ---
(In reply to comment #3)
> > This is is far less important that running the tests as part of the build, but
> > I think that the tests should be renamed for consistency and as it just allows
> > to use name patterns to select the tests (currently there is no convention
> > here). In the current state of the test suite, I would prefer to select the
> > tests by name pattern rather than having a TestAll as it doesn't have any
> > advantage and this file needs to be modified each time a test is added (with
> > the risk to have tests that aren't run).
> That is a reasonable argument. Patches tend to get very large when renames are
> concerned. A set of svn commands to run would be easier to review and to apply.

Isn't it even more efficient if one committer (you?) just rename the files and
commit the changes?

> > I don't understand either why you don't use Ant's junit task.
> No idea. Merging the test.xml with the main build.xml and using Ant's junit
> task would make sense.

this was in the proposed patch. Should I upload an other one?

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message