tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 47124] Run the unit tests as part of the build!!!
Date Mon, 04 May 2009 14:58:57 GMT

--- Comment #3 from Mark Thomas <>  2009-05-04 07:58:53 PST ---
(In reply to comment #2)
> Tests *should* be integral part of the build. It's normal that a build takes
> (far) longer than 5 minutes if it runs tests (nevertheless these tests should
> have some sense to be worth this time, what is perhaps not yet the case).
Running the tests as part of the Gump build would make sense. Changing the
build we use all the time in development from 1s to >5min does not.

> I'm sorry if I didn't followed the convention for external libs. I thought that
> it was the case. What about using Ivy rather than this self made "strategy"?
Changing this is a separate question for the dev list. As with any change,
there would need to sufficient benefit to justify it.

> This is is far less important that running the tests as part of the build, but
> I think that the tests should be renamed for consistency and as it just allows
> to use name patterns to select the tests (currently there is no convention
> here). In the current state of the test suite, I would prefer to select the
> tests by name pattern rather than having a TestAll as it doesn't have any
> advantage and this file needs to be modified each time a test is added (with
> the risk to have tests that aren't run).
That is a reasonable argument. Patches tend to get very large when renames are
concerned. A set of svn commands to run would be easier to review and to apply.

> I don't understand either why you don't use Ant's junit task.
No idea. Merging the test.xml with the main build.xml and using Ant's junit
task would make sense.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message