tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 47124] Run the unit tests as part of the build!!!
Date Mon, 04 May 2009 12:07:37 GMT

--- Comment #2 from Marc Guillemot <>  2009-05-04 05:07:33 PST ---
I'm glad to see that you've committed some changes, nevertheless for me it
doesn't really change the situation that unit tests are not considered
seriously in Tomcat project.

Tests *should* be integral part of the build. It's normal that a build takes
(far) longer than 5 minutes if it runs tests (nevertheless these tests should
have some sense to be worth this time, what is perhaps not yet the case).

I'm sorry if I didn't followed the convention for external libs. I thought that
it was the case. What about using Ivy rather than this self made "strategy"?

This is is far less important that running the tests as part of the build, but
I think that the tests should be renamed for consistency and as it just allows
to use name patterns to select the tests (currently there is no convention
here). In the current state of the test suite, I would prefer to select the
tests by name pattern rather than having a TestAll as it doesn't have any
advantage and this file needs to be modified each time a test is added (with
the risk to have tests that aren't run).

I don't understand either why you don't use Ant's junit task.

At the end I have the feeling that this issue has been closed as WONTFIX rather
than as FIXED :-(

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message