tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47124] Run the unit tests as part of the build!!!
Date Sat, 02 May 2009 23:20:17 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47124


Mark Thomas <markt@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Mark Thomas <markt@apache.org>  2009-05-02 16:20:16 PST ---
I am -1 for this patch as is on the following grounds:
- The tests take far too long to run by default with every build. This patch
increases the rebuild time from 1s to over 5min.
- The patch doesn't follow the Tomcat convention for defining external libs

I'm also very close to -1 on the renaming. I don't think it adds that much.

Given this, what I have done is modified the current test/build.xml in trunk to
run all the tests. There are currently see a number of errors/failures - mostly
in Tribes. How many of those are genuine and how many are faulty tests is TBD.
Given the failures and the time taken, the Tribes tests are currently commented
out.

The remaining failures are caused by the use of ServerFactory that doesn't play
nicely with o.a.c.startup.Tomcat when multiple Tomcat instance are created.

As noted in the code ServerFactory needs to be removed.

Several resolutions are applicable here, I went for FIXED.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message