tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47061] JDBCStore for saving sessions doesn't support datasource
Date Fri, 01 May 2009 15:48:58 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47061


Mark Thomas <markt@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement




--- Comment #2 from Mark Thomas <markt@apache.org>  2009-05-01 08:48:56 PST ---
A couple of comments on your patch:
- It appears to more than advertised - eg moving the call to remove(). Should
this be a separate issue?
- The documentation is not updated.
- Think about the visibility of the new attributes and methods you are adding.
I'd probably start them off as private and increase visibility of required.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message