tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r769734 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java
Date Wed, 29 Apr 2009 13:12:35 GMT
As I mentioned in the bug report, what is the benefit of this?

Filip

markt@apache.org wrote:
> Author: markt
> Date: Wed Apr 29 10:22:00 2009
> New Revision: 769734
>
> URL: http://svn.apache.org/viewvc?rev=769734&view=rev
> Log:
> Reduce scope - partial application of patch by Jens Kapitza from bug 46999
>
> Modified:
>     tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java
>
> Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java?rev=769734&r1=769733&r2=769734&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java Wed Apr
29 10:22:00 2009
> @@ -32,7 +32,7 @@
>   */
>  public class ThreadPoolExecutor extends java.util.concurrent.ThreadPoolExecutor {
>      
> -    final AtomicInteger activeCount = new AtomicInteger(0);
> +    private final AtomicInteger activeCount = new AtomicInteger(0);
>      
>      public ThreadPoolExecutor(int corePoolSize, int maximumPoolSize, long keepAliveTime,
TimeUnit unit, BlockingQueue<Runnable> workQueue, RejectedExecutionHandler handler)
{
>          super(corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, handler);
> @@ -92,7 +92,7 @@
>              super.execute(command);
>          } catch (RejectedExecutionException rx) {
>              if (super.getQueue() instanceof TaskQueue) {
> -                TaskQueue queue = (TaskQueue)super.getQueue();
> +                final TaskQueue queue = (TaskQueue)super.getQueue();
>                  try {
>                      if (!queue.force(command, timeout, unit)) {
>                          throw new RejectedExecutionException("Queue capacity is full.");
> @@ -108,7 +108,7 @@
>          }
>      }
>      
> -    static class RejectHandler implements java.util.concurrent.RejectedExecutionHandler
{
> +    private static class RejectHandler implements java.util.concurrent.RejectedExecutionHandler
{
>          public void rejectedExecution(Runnable r, java.util.concurrent.ThreadPoolExecutor
executor) {
>              throw new RejectedExecutionException();
>          }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message