tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Some questions about the AccessLogValve
Date Thu, 02 Apr 2009 10:38:11 GMT
Xie Xiaodong wrote:
> Hello, Dear All,
>    I found that "Double-Checked Locking Pattern" are heavily used in
> AccessLogValve to get rid of race condition. But as far as I know, this
> pattern will not work in Java according to this article:
> http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html. I
> think this part need to be revised to get rid of race condition for sure.

Good catch.

Looks like we need some volatiles in there. The best thing to do would be:
- create a bugzilla entry for this (do it against Tomcat 6)
- fix the problems
- attach a patch (in diff -u format) to the bugzilla issue
- one of the committers will review your patch and apply if it is OK

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message