Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.217.179 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=QUEht1hg/hcXqXIyKT1+UlLRDUcHatiRHKjEnyYIIdMxU5Zjt1pRXm/+EnzI9vKMK0
         YUNPjvYc0M9tfi/X0DcLPgYkmBRcPTfjDd+Xk1AEASxYyWiFnN0uo1m9cGuKDic1h/Np
         Mgd8k2InHmyiPpowRquJQxHdQPFW7EoSJa1MY=
MIME-Version: 1.0
In-Reply-To: <49C80B7E.8090408@hanik.com>
References: <20090323120739.B30892388970@eris.apache.org>
	 <25aac9fc0903230615o330f7e64j5ffaa62295ba79e4@mail.gmail.com>
	 <49C7A07A.9020400@hanik.com>
	 <25aac9fc0903231322g644c21ehc44e4f75afd0bf34@mail.gmail.com>
	 <49C80B7E.8090408@hanik.com>
Date: Tue, 24 Mar 2009 11:36:49 +0000
Message-ID: <25aac9fc0903240436k671e2f65p67a588b078737387@mail.gmail.com>
Subject: Re: svn commit: r757381 -
 /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
From: sebb <sebbaz@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 23/03/2009, Filip Hanik - Dev Lists <devlists@hanik.com> wrote:
> sebb wrote:
>
> > Since it's a new variable,
> >
>  define new

Has pool been released yet?

>
> > one can make it private now without
> > breaking anything.
> >
> > Every little helps.
> >
> > On 23/03/2009, Filip Hanik - Dev Lists <devlists@hanik.com> wrote:
> >
> >
> > > one could also make a toilet made out of solid gold, but it's just not
> in
> > > the cards now is it?
> > >  http://www.imdb.com/character/ch0002425/quotes
> > >
> > >
> > >
> > >
> > >  sebb wrote:
> > >
> > >
> > >
> > > > On 23/03/2009, fhanik@apache.org <fhanik@apache.org> wrote:
> > > >
> > > >
> > > >
> > > >
> > > > > Author: fhanik
> > > > >  Date: Mon Mar 23 12:07:36 2009
> > > > >  New Revision: 757381
> > > > >
> > > > >  URL:
> http://svn.apache.org/viewvc?rev=757381&view=rev
> > > > >  Log:
> > > > >  expose the poolname through a public method, this will allow one to
> > > > >
> > > > >
> > > >
> > > retrieve the actual connection pool through JMX as well
> > >
> > >
> > > >
> > > > >  Modified:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
> > >
> > >
> > > >
> > > > >  Modified:
> > > > >
> > > > >
> > > >
> > >
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
> > >
> > >
> > > >
> > > > >  URL:
> > > > >
> > > > >
> > > >
> > >
> http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java?rev=757381&r1=757380&r2=757381&view=diff
> > >
> ==============================================================================
> > >
> > >
> > > >
> > > > >  ---
> > > > >
> > > > >
> > > >
> > >
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
> > > (original)
> > >
> > >
> > > >
> > > > >  +++
> > > > >
> > > > >
> > > >
> > >
> tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
> > > Mon Mar 23 12:07:36 2009
> > >
> > >
> > > >
> > > > >  @@ -44,10 +44,6 @@
> > > > >
> > > > >    protected volatile ConnectionPool pool = null;
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > Since getPool() is public, one could make the variable private.
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > >  -    public ConnectionPool getPool() {
> > > > >  -        return pool;
> > > > >  -    }
> > > > >  -
> > > > >    protected PoolProperties poolProperties = new PoolProperties();
> > > > >
> > > > >    public DataSourceProxy() {
> > > > >  @@ -125,6 +121,14 @@
> > > > >                                                String password)
> throws
> > > > >
> > > > >
> > > >
> > > SQLException {
> > >
> > >
> > > >
> > > > >        return (PooledConnection) getConnection();
> > > > >    }
> > > > >  +
> > > > >  +    public ConnectionPool getPool() {
> > > > >  +        return pool;
> > > > >  +    }
> > > > >  +
> > > > >  +    public String getPoolName() {
> > > > >  +        return pool.getName();
> > > > >  +    }
> > > > >
> > > > >    /**
> > > > >     * {@inheritDoc}
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> ---------------------------------------------------------------------
> > >
> > >
> > > >
> > > > >  To unsubscribe, e-mail:
> > > > >
> > > > >
> > > >
> > > dev-unsubscribe@tomcat.apache.org
> > >
> > >
> > > >
> > > > >  For additional commands, e-mail: dev-help@tomcat.apache.org
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> ---------------------------------------------------------------------
> > >
> > >
> > > > To unsubscribe, e-mail:
> dev-unsubscribe@tomcat.apache.org
> > > > For additional commands, e-mail: dev-help@tomcat.apache.org
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> ---------------------------------------------------------------------
> > >  To unsubscribe, e-mail:
> dev-unsubscribe@tomcat.apache.org
> > >  For additional commands, e-mail: dev-help@tomcat.apache.org
> > >
> > >
> > >
> > >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>  For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org