Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of matkovitsg@msn.com designates
 65.54.246.172 as permitted sender)
Message-ID: <BAY136-W8F55898BC635286DD316DC6CA0@phx.gbl>
Content-Type: multipart/alternative;
	boundary="_1d8ddecc-93a3-4149-9f4b-5b4124431626_"
From: George MATKOVITS <matkovitsg@msn.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: RE: View towards refactoring changes?
Date: Mon, 26 Jan 2009 17:24:05 -0600
Importance: Normal
In-Reply-To: <497D69F6.90804@mustardgrain.com>
References: <497D69F6.90804@mustardgrain.com>
MIME-Version: 1.0

--_1d8ddecc-93a3-4149-9f4b-5b4124431626_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable


Tomcat seems to be becoming reasonably stable again. Please do not disturb =
the code base for a few more months. These are 'nice' improvements but IMO =
not worth the potentially new bugs! Thank you -- George

> Date: Sun=2C 25 Jan 2009 23:44:54 -0800
> From: kirk@mustardgrain.com
> To: dev@tomcat.apache.org
> Subject: View towards refactoring changes?
>=20
> Hi all=2C
>=20
> There are a number of places in NioEndpoint and JIoEndpoint that share a=
=20
> good portion of common code. The accessors for common properties take up=
=20
> a good chunk=2C but there's also some boilerplate code for checking if=20
> we're paused=2C running=2C etc. There are a lot of places where variable =
and=20
> method scope could be cleaned up too.
>=20
> Obviously I can't commit this code myself=2C but if I submitted patches=20
> for it=2C would they be looked upon favorably or ignored as noise? :)
>=20
> Thanks=2C
> Kirk
>=20
> ---------------------------------------------------------------------
> To unsubscribe=2C e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands=2C e-mail: dev-help@tomcat.apache.org
>=20

--_1d8ddecc-93a3-4149-9f4b-5b4124431626_--