tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From George MATKOVITS <matkovi...@msn.com>
Subject RE: View towards refactoring changes?
Date Mon, 26 Jan 2009 23:24:05 GMT

Tomcat seems to be becoming reasonably stable again. Please do not disturb the code base for
a few more months. These are 'nice' improvements but IMO not worth the potentially new bugs!
Thank you -- George

> Date: Sun, 25 Jan 2009 23:44:54 -0800
> From: kirk@mustardgrain.com
> To: dev@tomcat.apache.org
> Subject: View towards refactoring changes?
> 
> Hi all,
> 
> There are a number of places in NioEndpoint and JIoEndpoint that share a 
> good portion of common code. The accessors for common properties take up 
> a good chunk, but there's also some boilerplate code for checking if 
> we're paused, running, etc. There are a lot of places where variable and 
> method scope could be cleaned up too.
> 
> Obviously I can't commit this code myself, but if I submitted patches 
> for it, would they be looked upon favorably or ignored as noise? :)
> 
> Thanks,
> Kirk
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message