Return-Path: 
 <dev-return-93172-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org>
Delivered-To: apmail-tomcat-dev-archive@www.apache.org
Received: (qmail 55328 invoked from network); 8 Dec 2008 16:27:44 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 8 Dec 2008 16:27:44 -0000
Received: (qmail 19707 invoked by uid 500); 8 Dec 2008 16:27:55 -0000
Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org
Received: (qmail 19659 invoked by uid 500); 8 Dec 2008 16:27:55 -0000
Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@tomcat.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@tomcat.apache.org>
List-Post: <mailto:dev@tomcat.apache.org>
List-Id: <dev.tomcat.apache.org>
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Delivered-To: mailing list dev@tomcat.apache.org
Received: (qmail 19648 invoked by uid 99); 8 Dec 2008 16:27:55 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Dec 2008 08:27:55 -0800
X-ASF-Spam-Status: No, hits=1.2 required=10.0
	tests=SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received: from [212.27.42.65] (HELO smtp8-g19.free.fr) (212.27.42.65)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Dec 2008 16:26:24 +0000
Received: from smtp8-g19.free.fr (localhost [127.0.0.1])
	by smtp8-g19.free.fr (Postfix) with ESMTP id 0CE2432A805
	for <dev@tomcat.apache.org>; Mon,  8 Dec 2008 17:27:10 +0100 (CET)
Received: from [192.168.0.11] (lap34-1-82-224-140-72.fbx.proxad.net
 [82.224.140.72])
	by smtp8-g19.free.fr (Postfix) with ESMTP id DB67532A817
	for <dev@tomcat.apache.org>; Mon,  8 Dec 2008 17:27:09 +0100 (CET)
Subject: Re: Executor - package dependencies
From: Remy Maucherat <remm@apache.org>
To: Tomcat Developers List <dev@tomcat.apache.org>
In-Reply-To: <493D4592.8060104@hanik.com>
References: <493D4592.8060104@hanik.com>
Content-Type: text/plain; charset=utf-8
Date: Mon, 08 Dec 2008 17:27:08 +0100
Message-Id: <1228753628.3012.18.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) 
Content-Transfer-Encoding: 8bit
X-Virus-Checked: Checked by ClamAV on apache.org

On Mon, 2008-12-08 at 09:04 -0700, Filip Hanik - Dev Lists wrote:
> The executor, the way we have optimized it works really well now.
> 
> I'd like to get rid of all thread pooling inside the NIO connector, but 
> that would create a funky package dependency from tomcat-coyote.jar -> 
> catalina.jar
> 
> 
> any thoughts on how we could structure this so that the thread pool 
> (<Executor> interface) could be reused in other parts of tomcat code?

Components should use the java.util.concurrent.Excutor interface, the
other one adds Lifecycle and that's it.

I see you broke that design by Filipizing it and broke that design. It
is up to you to solve your own problems, I think ;)

Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org