tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46221] Leak WebappClassLoader with commons-logging and log4j
Date Wed, 03 Dec 2008 14:27:37 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46221





--- Comment #4 from Arnaud de Bossoreille <debossoreille@idm.fr>  2008-12-03 06:27:36
PST ---
I am also using the manager via the web interface but with the start/stop links
of the webapp.

I am a little bit confused by the plumbing of tomcat's objects, that is why I
do not always see what is involved. However it seems that your patch in
StandardPipeline.java is better than what I did in StandardContext.java for the
same purpose, because it handles more instances than those created by the
StandardContext.

My test showed that 3 valves are concerned by the releaseContainerLog calls.
But maybe not all of them have a reference on the WebappClassLoader (I did not
check). The valves I see (System.err.println(current);) are:

    - org.apache.catalina.core.StandardWrapperValve[jsp]
    - org.apache.catalina.core.StandardWrapperValve[default]
    - org.apache.catalina.core.StandardContextValve[/logging-leak]

I suppose my patch handled only the last one.

Moreover, you may have more valves than I have. This would explain why my patch
did not work for you (I guess).

I created the patch I last used so that you can review it (I will add it as a
new attachement).


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message