Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 8236 invoked from network); 23 Nov 2008 21:13:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Nov 2008 21:13:42 -0000 Received: (qmail 55386 invoked by uid 500); 23 Nov 2008 21:13:50 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 55333 invoked by uid 500); 23 Nov 2008 21:13:50 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 55322 invoked by uid 99); 23 Nov 2008 21:13:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Nov 2008 13:13:50 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [193.252.22.190] (HELO smtp6.freeserve.com) (193.252.22.190) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Nov 2008 21:12:25 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3614.me.freeserve.com (SMTP Server) with ESMTP id 1C8A97000086 for ; Sun, 23 Nov 2008 22:13:00 +0100 (CET) Received: from smtp.homeinbox.net (unknown [91.109.178.121]) by mwinf3614.me.freeserve.com (SMTP Server) with ESMTP id 059C47000085 for ; Sun, 23 Nov 2008 22:13:00 +0100 (CET) X-ME-UUID: 20081123211300230.059C47000085@mwinf3614.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by smtp.homeinbox.net (Postfix) with ESMTP id F1DD81A46A2 for ; Sun, 23 Nov 2008 21:13:12 +0000 (GMT) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from smtp.homeinbox.net ([127.0.0.1]) by localhost (server01.dev.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iayrSd+Zf--h for ; Sun, 23 Nov 2008 21:13:10 +0000 (GMT) Received: from macbook.local (unknown [192.168.0.202]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.homeinbox.net (Postfix) with ESMTPSA id EBA701A4672 for ; Sun, 23 Nov 2008 21:13:09 +0000 (GMT) Message-ID: <4929C74E.2070303@apache.org> Date: Sun, 23 Nov 2008 21:12:46 +0000 From: Mark Thomas User-Agent: Thunderbird 2.0.0.18 (Macintosh/20081105) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r719626 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java References: <20081121163146.ACBB9238889E@eris.apache.org> <49273BA2.1080103@apache.org> <492862D5.5060502@hanik.com> <49292024.1090508@apache.org> <4929C5B4.6010905@hanik.com> In-Reply-To: <4929C5B4.6010905@hanik.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Filip Hanik - Dev Lists wrote: > While cleaning up sounds tempting, it's been tried before. > I'd rather not do it, just for the sake of cleanup. The connectors have > way too many edge cases to work around, and they are fairly easy to break. > There are plenty of new features to add in for servlet 3.0, and cleanup > will most likely only destabilize and introduce new bugs, with nothing > or little gained One area where I think there may be benefit is reducing the chances of failing to fix the same bug in multiple connectors. Anything other than where the code is identical between the connectors is probably asking for trouble. I'll take a look at this at some point (which may or may result in some patches), but there is plenty of other cleanup to do first. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org