Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4924950C.2000802@apache.org>
Date: Wed, 19 Nov 2008 22:37:00 +0000
From: Mark Thomas <markt@apache.org>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: [VOTE] Release build 4.1.39
References: <492400AD.8000204@apache.org>
	 <25aac9fc0811191137g2e2f2eahff2db20cb39a0490@mail.gmail.com>
	 <25aac9fc0811191218x37e4c78o6f979119a6718e0e@mail.gmail.com>
	 <4924757C.7010501@apache.org>
	 <25aac9fc0811191323s1c877618wdcc0c7a5573911a9@mail.gmail.com>
	 <4924858F.6020308@apache.org>
	 <25aac9fc0811191345u62cf9761l76c7d69e0ee2883b@mail.gmail.com>
	 <49248A7A.2020105@apache.org>
 <25aac9fc0811191434m1c10003bn78bb3b1e8fa3f3e1@mail.gmail.com>
In-Reply-To: <25aac9fc0811191434m1c10003bn78bb3b1e8fa3f3e1@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

sebb wrote:
> On 19/11/2008, Mark Thomas <markt@apache.org> wrote:
>> sebb wrote:
>>  > On 19/11/2008, Mark Thomas <markt@apache.org> wrote:
>>  >> sebb wrote:
>>  >>  > On 19/11/2008, Mark Thomas <markt@apache.org> wrote:
>>  >>  >> sebb wrote:
>>  >>  >>  > On 19/11/2008, sebb <sebbaz@gmail.com> wrote:
>>  >>  >>  >> On 19/11/2008, Mark Thomas <markt@apache.org> wrote:
>>  >>  >>  >>
>>  >>  >>  >>> The source tarball and other packages are available here:
>>  >>  >>  >>  >  http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39/
>>  >>  >>  >>
>>  >>  >>  >
>>  >>  >>  > I just ran RAT on the source archive.
>>  >>  >>  >
>>  >>  >>  > There are a lot of source files that don't have the standard AL headers.
>>  >>  >>  > Some of these are test files or 3rd party files, but there are still
>>  >>  >>  > quite a few that should have the AL headers, for example various make
>>  >>  >>  > files, build.xml files, example Java files.
>>  >>  >>  > Some source files have existing ASF copyright headers such as:
>>  >>  >>  >
>>  >>  >>  >   Copyright (c) 1999 The Apache Software Foundation.  All rights
>>  >>  >>  >   reserved.
>>  >>  >>  >
>>  >>  >>  > which ought to be replaced by the AL header.
>>  >>  >>
>>  >>  >>
>>  >>  >> Care to provide the results to save me having to repeat the exercise?
>>  >>  >>  Better yet, how about providing some patches to go along with some of these
>>  >>  >>  reports of yours?
>>  >>  >>
>>  >>  >
>>  >>  > I ran the report on the source archive.
>>  >>  >
>>  >>  > I could not find the corresponding place(s) in SVN.
>>  >>
>>  >>
>>  >> http://tomcat.apache.org
>>  >>
>>  >>  You want the link on the left hand side called "SVN Repositories"
>>  >
>>  > I meant where to find the tag directory for the release 4.1.39.
>>
>>
>> It is in your inbox. Look at the svn commit messages.
> 
> Which all seem to be against trunk, i.e. not a tag.

I meant the commits to create the tags.

>>  Anyway, patches should be against the current 4.1.x trunk.
> 
> Will patches against current-svn15/tc4.1.x be OK?

Absolutely. That is always the way we work. We don't apply patches to tags.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org