Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 54032 invoked from network); 19 Nov 2008 21:45:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Nov 2008 21:45:45 -0000 Received: (qmail 95605 invoked by uid 500); 19 Nov 2008 21:45:46 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 95538 invoked by uid 500); 19 Nov 2008 21:45:46 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 95522 invoked by uid 99); 19 Nov 2008 21:45:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2008 13:45:46 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 64.233.182.190 as permitted sender) Received: from [64.233.182.190] (HELO nf-out-0910.google.com) (64.233.182.190) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2008 21:44:24 +0000 Received: by nf-out-0910.google.com with SMTP id c10so88923nfd.44 for ; Wed, 19 Nov 2008 13:45:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=amXY73vBT4HvRMsH6fyhH160zqckoTiHZAzlO8ABXt8=; b=oJqQHZzn/fkHTlqIKsKcdNkhOnoZq5oG0H3UCPqtwqHmM+8B7LgkxrxTcc/im3rxfG gYW224VIZAs/L0ETUFJsbReshTwStDckgls/L/BPIy4z+ARNq6B5KJgMTJX0qMsfCnS+ Y6VIiL6KyFyvfP3SNprsfHluVePsYu9vYwWVs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=AwYv8+5hUdu8W5m4IiD257JVPL5Zyb1QF1XqWWtKE8hQ3xCUULhInYibptMiyhi/vD cDcFeTrzHKLMY/EeX0Iez/RRBq7YrP3Dt7Qozz7MhSquKrJvFl0qAnD/FhF8xPBiUtZ/ 2Hz9t8dIVLFwPake4K5pSJZm/5Vr3DNRUhvtg= Received: by 10.86.29.8 with SMTP id c8mr1017261fgc.67.1227131107486; Wed, 19 Nov 2008 13:45:07 -0800 (PST) Received: by 10.86.65.7 with HTTP; Wed, 19 Nov 2008 13:45:07 -0800 (PST) Message-ID: <25aac9fc0811191345u62cf9761l76c7d69e0ee2883b@mail.gmail.com> Date: Wed, 19 Nov 2008 21:45:07 +0000 From: sebb To: "Tomcat Developers List" Subject: Re: [VOTE] Release build 4.1.39 In-Reply-To: <4924858F.6020308@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <492400AD.8000204@apache.org> <25aac9fc0811191137g2e2f2eahff2db20cb39a0490@mail.gmail.com> <25aac9fc0811191218x37e4c78o6f979119a6718e0e@mail.gmail.com> <4924757C.7010501@apache.org> <25aac9fc0811191323s1c877618wdcc0c7a5573911a9@mail.gmail.com> <4924858F.6020308@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org On 19/11/2008, Mark Thomas wrote: > sebb wrote: > > On 19/11/2008, Mark Thomas wrote: > >> sebb wrote: > >> > On 19/11/2008, sebb wrote: > >> >> On 19/11/2008, Mark Thomas wrote: > >> >> > >> >>> The source tarball and other packages are available here: > >> >> > http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39/ > >> >> > >> > > >> > I just ran RAT on the source archive. > >> > > >> > There are a lot of source files that don't have the standard AL headers. > >> > Some of these are test files or 3rd party files, but there are still > >> > quite a few that should have the AL headers, for example various make > >> > files, build.xml files, example Java files. > >> > Some source files have existing ASF copyright headers such as: > >> > > >> > Copyright (c) 1999 The Apache Software Foundation. All rights > >> > reserved. > >> > > >> > which ought to be replaced by the AL header. > >> > >> > >> Care to provide the results to save me having to repeat the exercise? > >> Better yet, how about providing some patches to go along with some of these > >> reports of yours? > >> > > > > I ran the report on the source archive. > > > > I could not find the corresponding place(s) in SVN. > > > http://tomcat.apache.org > > You want the link on the left hand side called "SVN Repositories" I meant where to find the tag directory for the release 4.1.39. > Also, note the fix I just applied to the SVN URLs for current-svn15 if you > use a 1.5+ client. > I do; that will be useful. > Mark > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org