Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 64.233.182.189 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=mosxxHrWP6abqAQgqu7vqCSSWmNhnXLNZT3iGgo3wCCmI5lukqeYc+05Ytf1A7SF+o
         PBh6SVXIn7aObYS9fQZiF6fzzAqx9PjQpUNy8JvDR8ygCyWGrZr+bXf+0cnjcPDB2gM1
         GOV95WZAfX859SFTE0YuUbiSVaJj3AdaEc2Eg=
Message-ID: <25aac9fc0811180624w6308fa1fof0a2fdd07fea3d24@mail.gmail.com>
Date: Tue, 18 Nov 2008 14:24:58 +0000
From: sebb <sebbaz@gmail.com>
To: "Tomcat Developers List" <dev@tomcat.apache.org>
Subject: Re: [RESULT] [VOTE] Releasing Apache Tomcat Native 1.1.16
In-Reply-To: <4922CCE5.4010702@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <491C48C7.7070206@apache.org> <49226207.8010804@apache.org>
	 <49226DF6.4030909@rowe-clan.net> <49226FE9.9000700@apache.org>
	 <25aac9fc0811180553k2aa3fd8dj5f8a6bceba30395e@mail.gmail.com>
	 <4922CCE5.4010702@apache.org>

On 18/11/2008, Mladen Turk <mturk@apache.org> wrote:
> sebb wrote:
>
> > I happened to spot the following in ssl.c:
> >
> > static int jbs_gets(BIO *b, char *out, int outl)
> > ...
> > int l = (int)strlen(J2S(o));
> > if (l < outl) {
> >    strcpy(out, J2S(o));
> >    ret = outl;
> > }
> > ...
> > return ret;
> >
> > It looks a bit odd to me - I would have expected it to return l rather
> > than outl.
> >
> > However, I've no idea what the function API is supposed to be - and
> > the caller can use strlen(out) to find l -  so I'm probably wrong.
> >
> >
> >
>
>  You are probably right, but the entire BIO code
>  isn't used anywhere. It was something we
>  (Jean-Frederic I think) experimented at the
>  beginning.

Perhaps it should be removed then, or at least commented out.
Seems rather risky to me to have unused JNI code in a release.

>  Regards
>  --
>  ^(TM)
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>  For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org