tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: [VOTE] Release build 4.1.39
Date Wed, 19 Nov 2008 22:37:00 GMT
sebb wrote:
> On 19/11/2008, Mark Thomas <markt@apache.org> wrote:
>> sebb wrote:
>>  > On 19/11/2008, Mark Thomas <markt@apache.org> wrote:
>>  >> sebb wrote:
>>  >>  > On 19/11/2008, Mark Thomas <markt@apache.org> wrote:
>>  >>  >> sebb wrote:
>>  >>  >>  > On 19/11/2008, sebb <sebbaz@gmail.com> wrote:
>>  >>  >>  >> On 19/11/2008, Mark Thomas <markt@apache.org>
wrote:
>>  >>  >>  >>
>>  >>  >>  >>> The source tarball and other packages are available
here:
>>  >>  >>  >>  >  http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39/
>>  >>  >>  >>
>>  >>  >>  >
>>  >>  >>  > I just ran RAT on the source archive.
>>  >>  >>  >
>>  >>  >>  > There are a lot of source files that don't have the standard
AL headers.
>>  >>  >>  > Some of these are test files or 3rd party files, but there
are still
>>  >>  >>  > quite a few that should have the AL headers, for example
various make
>>  >>  >>  > files, build.xml files, example Java files.
>>  >>  >>  > Some source files have existing ASF copyright headers such
as:
>>  >>  >>  >
>>  >>  >>  >   Copyright (c) 1999 The Apache Software Foundation.  All
rights
>>  >>  >>  >   reserved.
>>  >>  >>  >
>>  >>  >>  > which ought to be replaced by the AL header.
>>  >>  >>
>>  >>  >>
>>  >>  >> Care to provide the results to save me having to repeat the exercise?
>>  >>  >>  Better yet, how about providing some patches to go along with
some of these
>>  >>  >>  reports of yours?
>>  >>  >>
>>  >>  >
>>  >>  > I ran the report on the source archive.
>>  >>  >
>>  >>  > I could not find the corresponding place(s) in SVN.
>>  >>
>>  >>
>>  >> http://tomcat.apache.org
>>  >>
>>  >>  You want the link on the left hand side called "SVN Repositories"
>>  >
>>  > I meant where to find the tag directory for the release 4.1.39.
>>
>>
>> It is in your inbox. Look at the svn commit messages.
> 
> Which all seem to be against trunk, i.e. not a tag.

I meant the commits to create the tags.

>>  Anyway, patches should be against the current 4.1.x trunk.
> 
> Will patches against current-svn15/tc4.1.x be OK?

Absolutely. That is always the way we work. We don't apply patches to tags.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message