tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: [RESULT] [VOTE] Releasing Apache Tomcat Native 1.1.16
Date Tue, 18 Nov 2008 14:10:45 GMT
sebb wrote:
> I happened to spot the following in ssl.c:
> 
> static int jbs_gets(BIO *b, char *out, int outl)
> ...
> int l = (int)strlen(J2S(o));
> if (l < outl) {
>     strcpy(out, J2S(o));
>     ret = outl;
> }
> ...
> return ret;
> 
> It looks a bit odd to me - I would have expected it to return l rather
> than outl.
> 
> However, I've no idea what the function API is supposed to be - and
> the caller can use strlen(out) to find l -  so I'm probably wrong.
> 
> 

You are probably right, but the entire BIO code
isn't used anywhere. It was something we
(Jean-Frederic I think) experimented at the
beginning.

Regards
-- 
^(TM)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message