tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r710063 - /tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Date Mon, 03 Nov 2008 17:30:48 GMT
Remy Maucherat wrote:
> On Mon, 2008-11-03 at 14:28 +0000, markt@apache.org wrote:
>> Author: markt
>> Date: Mon Nov  3 06:28:17 2008
>> New Revision: 710063
>>
>> URL: http://svn.apache.org/viewvc?rev=710063&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42409
>> The spec says reset the buffer, therefore use the resetBuffer() method. This makes
custom and standard error handling consistent.
> 
> The flags for writer and output streams are no longer reset. This means
> an ISE in many cases. Is that what you want ?

Probably not. I'll look into this more carefully today.

> Personally, I don't think the spec's language should be followed here.

It is ambiguous but I am in favour of standard error pages and custom
error pages behaving in as similar a way as possible.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message