tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Kolinko" <knst.koli...@gmail.com>
Subject Re: svn commit: r718474 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioEndpoint.java SecureNioChannel.java
Date Tue, 18 Nov 2008 12:17:22 GMT
It would a bit better to use java.lang.StringBuilder instead of StringBuffer
here for code that runs on 1.5+ JVMs.

also, in theory, this toString() code may throw an NPE, though it looks like
it would not occur in practice.

Just in case if it matters.

Best regards,
Konstantin Kolinko

2008/11/18  <fhanik@apache.org>:
> Author: fhanik
> Date: Mon Nov 17 19:18:30 2008
> New Revision: 718474
>
> URL: http://svn.apache.org/viewvc?rev=718474&view=rev
> Log:
>
> Clean up debug a bit while troubleshooting
>
> (...)
> +    public String toString() {
> +        StringBuffer buf = new StringBuffer("[");
> +        buf.append(super.toString());
> +        buf.append("] ");
> +        buf.append("Netout buffer: pos="+this.netOutBuffer.position());
> (...)
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message