tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 46209] Findbugs report on Tomcat-Pool
Date Fri, 14 Nov 2008 21:54:21 GMT

Sebb <> changed:

           What    |Removed                     |Added
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |

--- Comment #8 from Sebb <>  2008-11-14 13:54:20 PST ---
(In reply to comment #7)
> There is nothing concrete here, just theory and style preferences. not actual
> bugs. If you wish to engage in coding style discussions, bugzilla is not the
> right forum, it would be more proper to take that discussion to the dev list

There *are* still some concrete items which remain to be fixed.

* M X OBL: Method org.apache.tomcat.jdbc.pool.PooledConnection.validate(int,
String) may fail to clean up stream or resource of type java.sql.Statement


* M B It: org.apache.tomcat.jdbc.pool.FairBlockingQueue$
can't throw NoSuchElementException

However it can throw ArrayOutOfBounds, which should be detected - and probably
converted to NoSuchElement.


* M D REC: Exception is caught when Exception is not thrown in

Not strictly a bug, but it makes debugging almost impossible if all Exceptions
are converted into SQLException.


The issues of thread-safety are not a matter of theory, they are a real
consequence of the Java Memory Model. However explaining that is probably best
left to the list.


I will take the other matters to the list.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message