tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r711589 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml
Date Wed, 05 Nov 2008 15:41:04 GMT
Author: markt
Date: Wed Nov  5 07:41:03 2008
New Revision: 711589

URL: http://svn.apache.org/viewvc?rev=711589&view=rev
Log:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46085
Hard to reproduce thread safety issue with session expiration

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt
    tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java
    tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=711589&r1=711588&r2=711589&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Nov  5 07:41:03 2008
@@ -187,16 +187,6 @@
   +1: fhanik, pero
   -1: 
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46085
-  Hard to reproduce thread safety issue with session expiration
-  http://svn.apache.org/viewvc?rev=708273&view=rev
-  +1: markt, fhanik, rjung
-   0: remm (volatile seems equivalent to an AtomicLong)
-        I did devise something by replacing the accessedTimes as long by an int offset
-        based on the creation date. From what I understand, this should also address
-        the corruption issue, but the patch is more complex. 
-  -1:
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46077
   Expose deferAccept
   Patch provided by Michael Leinartas

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java?rev=711589&r1=711588&r2=711589&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java Wed Nov  5
07:41:03 2008
@@ -204,7 +204,7 @@
     /**
      * The last accessed time for this Session.
      */
-    protected long lastAccessedTime = creationTime;
+    protected volatile long lastAccessedTime = creationTime;
 
 
     /**
@@ -279,7 +279,7 @@
     /**
      * The current accessed time for this session.
      */
-    protected long thisAccessedTime = creationTime;
+    protected volatile long thisAccessedTime = creationTime;
 
 
     /**

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=711589&r1=711588&r2=711589&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Wed Nov  5 07:41:03 2008
@@ -142,6 +142,10 @@
         (markt)
       </add>
       <fix>
+        <bug>46085</bug>: Fix a rare thread safety issue with session
+        expiration. (markt)
+      </fix>
+      <fix>
         <bug>46096</bug>:  Support annotation processing whilst running under
a
         security manager. (markt)
       </fix>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message