Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 54677 invoked from network); 3 Oct 2008 12:29:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Oct 2008 12:29:19 -0000 Received: (qmail 78839 invoked by uid 500); 3 Oct 2008 12:29:11 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 78789 invoked by uid 500); 3 Oct 2008 12:29:11 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 78778 invoked by uid 99); 3 Oct 2008 12:29:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2008 05:29:11 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [193.252.22.152] (HELO smtp5.freeserve.com) (193.252.22.152) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2008 12:28:09 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3424.me.freeserve.com (SMTP Server) with ESMTP id A86C01C00084 for ; Fri, 3 Oct 2008 14:28:43 +0200 (CEST) Received: from smtp.homeinbox.net (unknown [91.109.157.243]) by mwinf3424.me.freeserve.com (SMTP Server) with ESMTP id 910CA1C00082 for ; Fri, 3 Oct 2008 14:28:43 +0200 (CEST) X-ME-UUID: 20081003122843594.910CA1C00082@mwinf3424.me.freeserve.com Received: from localhost (localhost [127.0.0.1]) by smtp.homeinbox.net (Postfix) with ESMTP id E57451A4504 for ; Fri, 3 Oct 2008 13:28:48 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at homeinbox.net Received: from smtp.homeinbox.net ([127.0.0.1]) by localhost (server01.dev.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jM7XVIzyyseq for ; Fri, 3 Oct 2008 13:28:46 +0100 (BST) Received: from [192.168.0.4] (study01.dev.local [192.168.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.homeinbox.net (Postfix) with ESMTPSA id EF4531A4380 for ; Fri, 3 Oct 2008 13:28:45 +0100 (BST) Message-ID: <48E60FF6.4040602@apache.org> Date: Fri, 03 Oct 2008 13:28:38 +0100 From: Mark Thomas User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r701358 - /tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java References: <20081003120917.5A97E238889E@eris.apache.org> <1223036703.3127.0.camel@localhost.localdomain> In-Reply-To: <1223036703.3127.0.camel@localhost.localdomain> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Remy Maucherat wrote: > On Fri, 2008-10-03 at 12:09 +0000, markt@apache.org wrote: >> Author: markt >> Date: Fri Oct 3 05:09:16 2008 >> New Revision: 701358 >> >> URL: http://svn.apache.org/viewvc?rev=701358&view=rev >> Log: >> Better fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45403 >> With this patch, the allowLinking flag applies to all web application resources. It is very slightly slower. On my machine with allowLinking=false, the change to line 899 increases the time from ~7 microseconds to create the file to ~70 microseconds to create and validate the file. As far as I can tell, this change is only going to affect context start times. If directory listings are enabled in the default servlet, they will also be slightly slower but they were horribly slow to start with. > > Only 10 times slower :) True, but we are talking micro seconds so in absolute terms it isn't that much. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org