tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r708188 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Mon, 27 Oct 2008 14:06:45 GMT
Author: markt
Date: Mon Oct 27 07:06:44 2008
New Revision: 708188

URL: http://svn.apache.org/viewvc?rev=708188&view=rev
Log:
Propose Remy's alternative solution for string comp issue

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=708188&r1=708187&r2=708188&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Oct 27 07:06:44 2008
@@ -151,21 +151,6 @@
   +1: markt,fhanik
   -1: 
 
-* Fix String comparision bugs found by Find Bugs
-  http://svn.apache.org/viewvc?rev=699646&view=rev
-  +1: markt
-  -0: remm (actually, the optimization would be to return the original String
-            if it was not modified, and avoid doing things with a StringBuffer)
-    The simplest would be to add a (redundant) check at the beginning of replaceProperties,
-    and although the "bug" finder program would complain, I think the == check for the string
-    is acceptable:
-    public static String replaceProperties(String value, Hashtable staticProp,
-            PropertySource dynamicProp[]) {
-        if (value.indexOf("$") < 0) {
-            return value;
-        }
-        StringBuffer sb = new StringBuffer();
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45933
   Don't use xml parser from web-app to process tld files
   http://svn.apache.org/viewvc?rev=701355&view=rev
@@ -212,4 +197,9 @@
 * Fix read/write timeout during async comet access
   http://svn.apache.org/viewvc?rev=707670&view=rev 
   +1: fhanik, pero
-  -1:  
\ No newline at end of file
+  -1: 
+
+* Fix String comparison bugs found by Find Bugs using Remy's alternative solution
+  http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java?r1=708185&r2=708184&pathrev=708185
+  +1: markt
+  -1: 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message