tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 45931] trimSpaces incorrectly modifies output
Date Fri, 03 Oct 2008 17:22:50 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=45931





--- Comment #2 from Meetesh Karia <meetesh.karia@alumni.duke.edu>  2008-10-03 10:22:50
PST ---
Hi Mark,

Thanks for the comment.  The main question I have is whether you'd want to
leave the -trimspaces option for JspC backwards-compatible (ie, if there's no
"true", "false", or "single" after it, treat it as "true"), or whether you'd be
ok with changing the behavior to requiring the value after the flag.

Also, if there's anything else that's important to keep in mind when writing a
patch for tomcat, please share.

Thanks!

(In reply to comment #1)
> trimSpaces is equivalent to trimDirectiveWhitespaces
> 
> Section JSP.3.3.8 is clear that the whitespace must be removed completely.
> 
> trimSpaces can currently be true or false. I would not be against an
> enhancement that added the value "single" and in that case using the code in
> your patch.
> 
> Let us know if you need some pointers on writing a new patch.
> 


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message