Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 84621 invoked from network); 27 Sep 2008 17:38:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Sep 2008 17:38:25 -0000 Received: (qmail 82184 invoked by uid 500); 27 Sep 2008 17:38:16 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 82123 invoked by uid 500); 27 Sep 2008 17:38:16 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 82110 invoked by uid 99); 27 Sep 2008 17:38:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Sep 2008 10:38:16 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Sep 2008 17:37:23 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id CF56623888A3; Sat, 27 Sep 2008 10:37:57 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r699698 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c Date: Sat, 27 Sep 2008 17:37:57 -0000 To: dev@tomcat.apache.org From: rjung@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080927173757.CF56623888A3@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: rjung Date: Sat Sep 27 10:37:57 2008 New Revision: 699698 URL: http://svn.apache.org/viewvc?rev=699698&view=rev Log: Don't return error codes from GetLastError in init_jk, since JK_TRUE or JK_FALSE is expected. We shouldn't fail if watchdog thread could not be created, to keep behaviour consistent with mod_jk in Apache httpd. But increase log level of error to EMERG and log GetLastError. Modified: tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c Modified: tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c URL: http://svn.apache.org/viewvc/tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c?rev=699698&r1=699697&r2=699698&view=diff ============================================================================== --- tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c (original) +++ tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c Sat Sep 27 10:37:57 2008 @@ -1869,9 +1869,8 @@ watchdog_handle = CreateThread(NULL, 0, watchdog_thread, NULL, 0, &wi); if (!watchdog_handle) { - rc = GetLastError(); - jk_log(logger, JK_LOG_ERROR, "Error creating Watchdog thread"); - return rc; + jk_log(logger, JK_LOG_EMERG, "Error %d (0x%08x) creating Watchdog thread", + GetLastError(), GetLastError()); } } jk_log(logger, JK_LOG_INFO, "%s initialized", (VERSION_STRING)); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org