Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r698960 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date: Thu, 25 Sep 2008 13:21:15 -0000
To: dev@tomcat.apache.org
From: remm@apache.org
Message-Id: <20080925132115.C6F1223889FC@eris.apache.org>

Author: remm
Date: Thu Sep 25 06:21:15 2008
New Revision: 698960

URL: http://svn.apache.org/viewvc?rev=698960&view=rev
Log:
- Votes.

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=698960&r1=698959&r2=698960&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Sep 25 06:21:15 2008
@@ -146,20 +146,24 @@
 * More EL fixes. Add lookaheads to prevent parsing ambiguity
   http://svn.apache.org/viewvc?rev=696780&view=rev (the change)
   http://svn.apache.org/viewvc?rev=696782&view=rev (the auto generated code)
-  +1: mark
+  +1: mark, remm
   -1: 
 
 * Correct wrong "No role found" debug message,
   logged in RealmBase even if a role was found.
   http://svn.apache.org/viewvc?rev=697158&view=rev
-  +1: rjung, mturk, markt
+  +1: rjung, mturk, markt, remm
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45026
   Never use empty reason phrase.
   http://svn.apache.org/viewvc?rev=697183&view=rev
   +1: rjung, mturk, markt
-  -1: 
+  -1: remm (I think HttpMessages.getMessage should return something rather than null, 
+            most likely something like sc.ZZZ like you are doing, otherwise you need to fix
+            the APR implementation as well; 
+            if I understand correctly, trouble will occur with AJP if status is something 467,
+            with no message set)
 
 * Allow huge request body packets for AJP13.
   This was already applied to connectors, but never
@@ -167,32 +171,34 @@
   http://svn.apache.org/viewvc?rev=697192&view=rev
   Original change: http://svn.apache.org/viewvc?rev=486217&view=rev
   +1: rjung, mturk, markt
-  -1: 
+  -1: remm (- bodyMsg.appendInt(AjpConstants.MAX_READ_SIZE + packetSize - AjpConstants.MAX_PACKET_SIZE); looks wrong
+            - also partially applies to the two other AJP connectors
+            - not sure why forcing AjpConstants.MAX_PACKET_SIZE; either this shouldn't be done or the constant name should change)
 
 * Remove admin app from logging configuration
   http://svn.apache.org/viewvc?rev=698012&view=rev
-  +1: markt, rjung
+  +1: markt, rjung, remm
   -1: 
 
 * Add CombinedRealm and LockOutRealm with docs
   http://people.apache.org/~markt/patches/2008-09-24-lockout-realm.patch
-  +1: markt
+  +1: markt, remm (but you should stop adding features at some point)
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45852
   Add special handing to the Windows installer for a charset that doesn't follow
   the standard naming convention
   http://svn.apache.org/viewvc?rev=698613&view=rev
-  +1: markt, mturk
+  +1: markt, mturk, remm (arg, hack)
   -1: 
 
 * Update tc-native to lastest version:
   http://people.apache.org/~jfclere/patches/patch.new-tcnative
-  +1: jclere, markt
+  +1: jclere, markt, remm
   -1:
 
 * Backport "Remove unused code" in ELSupport.java.
   Keeps trunk and tc6 in sync and is no risk.
   http://svn.apache.org/viewvc?rev=649637&view=rev
-  +1: rjung, markt
+  +1: rjung, markt, remm (but cosmetic changes should stop in this branch)
   -1:


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org