tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 45823] New: AccessLogValve doesn't correctly handles combined log format (with patch)
Date Wed, 17 Sep 2008 09:20:06 GMT

           Summary: AccessLogValve doesn't correctly handles combined log
                    format (with patch)
           Product: Tomcat 6
           Version: 6.0.16
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina

Created an attachment (id=22595)
 --> (
Patch that corrects this bug

When configuring the AccessLogValve valve to use the combined log format and
either referer or user-agent fields are unavailable in the request, the
corresponding log entry fields will contain "(null)" instead of "-". This
behaviour breaks access log analyzers like AWStats and I believe it's also a
violation of the log spec.

Included is a patch that I believe will correct the problem. The patch make
sure that any non-existing header will be logged as '-' instead of trying to
log a null pointer.

I stumbled on this problem when upgrading from Tomcat 5.5 to 6.0.16 using
Debian etch and JDK 6. Tomcat 5.5 didn't suffer from this issue.

I haven't yet tried Tomcat 6.0.18 but the file seems to be
unchanged between the two releases so I suspect the problem still exists.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message