tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Mon, 29 Sep 2008 17:54:37 GMT
sebb wrote:
> BTW, Commons LANG has a thread-safe FastDateUtils which can be used
> for formatting (but not parsing) dates.
A whole jar for one method is somewhat overkill.

> Not sure why you did not just fix DateTool - e.g. by using ThreadLocal
> (or indeed synchronizing the use of DateFormats) - rather than fixing
> all calls to DateTool.
> Or maybe I've misunderstood something here.
The class served no purpose. There aren't lots of places using this code.

ThreadLocals and container classloader environments need careful handling
to avoid memory leaks. In this case the pain to make sure there wasn't a
memory leak wasn't worth the gain.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message