tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Thu, 18 Sep 2008 14:44:53 GMT
Remy Maucherat wrote:
> On Thu, 2008-09-18 at 14:41 +0100, Mark Thomas wrote:
>> Remy Maucherat wrote:
>>> On Thu, 2008-09-18 at 12:49 +0000, markt@apache.org wrote:
>>>> +      markt: No change in the TCK results with this patch. We have the
>>>> +             same EL related failures we have without the patch. I'll
>>>> +             look into them as separate issues.
>>> I fixed these by regenerating with a newer javacc and usage of the
>>> lookahead flag (3 looked sensible). Don't know which one actually fixed
>>> the problem.
>> So how come those changes haven't been checked back in to svn?
> 
> The problem looks minor (unless you're specifically interested in the
> TCK at a given point in time). I would have to know what actually fixed
> it, see if it works in Tomcat (it should) and then run the partial TCK
> with just Tomcat (I don't know how to do that :( ). So that's a lot of
> work, and I don't have time for it.

If you used a newer javacc and/or changed the lookahead for the 6.0.18
release that would have resulted in updated .java files. So again, my
question is why aren't the updated .java files in svn.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message