tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Findbugs results when run against Tomcat6
Date Fri, 26 Sep 2008 22:00:47 GMT
Just out of curiosity, I ran Findbugs 1.3.5 on Tomcat 6.0.18. The
default settings generated some  1400 warnings about possible bugs.

Quite a few of them look serious - assuming that the code which
contains them is being used.

For example, there are quite a few public static fields which are not final.

There are several instances of problems with String handling, e.g.
using == to compare Strings or using String.replace() without
assigning the result.

And there are a few instances of methods which synchronize on a field
in what appears to be an attempt to guard against simultaneous updates
to that field. But guarding a field gets a lock on the referenced
object, not on the field. This is probably not what was intended.

I can provide a listing of the analyis if required, but it might be
easier to use a FindBugs IDE plugin.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message