tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r699635 - /tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java
Date Sat, 27 Sep 2008 13:12:08 GMT
Author: markt
Date: Sat Sep 27 06:12:07 2008
New Revision: 699635

URL: http://svn.apache.org/viewvc?rev=699635&view=rev
Log:
Fix HTML decoding bug reported by Find Bugs

Modified:
    tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java

Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java?rev=699635&r1=699634&r2=699635&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java (original)
+++ tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java Sat Sep 27 06:12:07 2008
@@ -211,10 +211,10 @@
         if (val.indexOf('$') < 0 && val.indexOf('&') < 0) return val;
         
         // HTML decoding
-        val.replace("&lt;", "<");
-        val.replace("&gt;", ">");
-        val.replace("&quot;", "\"");
-        val.replace("&amp;", "&");
+        val = val.replace("&lt;", "<");
+        val = val.replace("&gt;", ">");
+        val = val.replace("&quot;", "\"");
+        val = val.replace("&amp;", "&");
 
         StringBuffer sb = new StringBuffer(val);
         int charStart = sb.indexOf("&#");



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message