tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r697050 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml
Date Fri, 19 Sep 2008 11:06:27 GMT
Author: markt
Date: Fri Sep 19 04:06:26 2008
New Revision: 697050

URL: http://svn.apache.org/viewvc?rev=697050&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45823
Log missing request headers as - not null
Based on a patch by Per Landberg

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt
    tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java
    tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=697050&r1=697049&r2=697050&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Sep 19 04:06:26 2008
@@ -153,13 +153,6 @@
              look into them as separate issues.
   -1: 
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45823
-  Log missing request headers as - not null
-  Based on a patch by Per Landberg
-  http://svn.apache.org/viewvc?rev=696234&view=rev
-  +1: markt, remm, pero
-  -1: 
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45441
   Correctly map filters for FORWARD and INCLUDE
   http://svn.apache.org/viewvc?rev=696240&view=rev

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=697050&r1=697049&r2=697050&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java Fri Sep 19 04:06:26
2008
@@ -1238,7 +1238,12 @@
 
         public void addElement(StringBuffer buf, Date date, Request request,
                 Response response, long time) {
-            buf.append(request.getHeader(header));
+            String value = request.getHeader(header);
+            if (value == null) {
+                buf.append('-');
+            } else {
+                buf.append(value);
+            }
         }
     }
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=697050&r1=697049&r2=697050&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Sep 19 04:06:26 2008
@@ -66,6 +66,10 @@
         <bug>45785</bug>: Ignore directories named xxx.jar in WEB-INF/lib.
         (markt)
       </fix>
+      <fix>
+        <bug>45823</bug>: Log missing request headers as '-' not 'null'. Based
+        on a patch by Per Landberg. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Coyote">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message