tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Holloway" <jonathan.hollo...@gmail.com>
Subject Re: Findbugs results when run against Tomcat6
Date Sat, 27 Sep 2008 00:21:25 GMT
You can also set this up to run as part of the Gump build and get the
warnings/errors
etc... recorded as part of a standard build.

Jon.

2008/9/26 sebb <sebbaz@gmail.com>

> Just out of curiosity, I ran Findbugs 1.3.5 on Tomcat 6.0.18. The
> default settings generated some  1400 warnings about possible bugs.
>
> Quite a few of them look serious - assuming that the code which
> contains them is being used.
>
> For example, there are quite a few public static fields which are not
> final.
>
> There are several instances of problems with String handling, e.g.
> using == to compare Strings or using String.replace() without
> assigning the result.
>
> And there are a few instances of methods which synchronize on a field
> in what appears to be an attempt to guard against simultaneous updates
> to that field. But guarding a field gets a lock on the referenced
> object, not on the field. This is probably not what was intended.
>
> I can provide a listing of the analyis if required, but it might be
> easier to use a FindBugs IDE plugin.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


-- 
Web: http://www.jonathanholloway.co.uk
Mail:  jonathan.holloway@gmail.com
IM:        jonathan_philip_holloway@hotmail.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message