tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 45613] use of generics in package org.apache.tomcat.util.http
Date Tue, 12 Aug 2008 19:13:11 GMT

--- Comment #4 from Mark Thomas <>  2008-08-12 12:13:11 PST ---
Can you remove the code formatting changes? Your first patch was much easier to
review. The later patches hid all the interesting stuff in amongst a huge
volume of  cosmetic changes.

Generally, we try and keep large cosmetic changes as completely separate
patches so all we have to do to review them is skim them to check no code has
changed. I did notice you were using a format for javadoc parameters that uses
a lot of whitespace. Also, it isn't a format that I am aware of us using
anywhere else in the codebase.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message