tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Gomez" <henri.go...@gmail.com>
Subject Re: [VOTE] Release tc-native 1.1.14
Date Thu, 03 Jul 2008 07:30:14 GMT
Where could we found, when release, the 1.1.14 for windows ?

Regards

2008/7/1 Rainer Jung <rainer.jung@kippdata.de>:
> Hi Jean-Frederic,
>
> jean-frederic clere schrieb:
>>
>> The candidates binaries are available here:
>> http://people.apache.org/~jfclere/tcnative/v1.1.14/
>>
>> According to the release process, the 1.1.14 tag is:
>> [ ] Broken
>> [ ] Alpha
>> [ ] Beta
>> [X] Stable
>
> Tested on Solaris 8. Library loads, threads show that it gets used, manager
> status shows extended OS information. Nevertheless see some minor comments
> below. I didn't test with OpenSSL or under high load though.
>
> On Windows I wasn't successful in building, because the build needs
> apr_arch_misc.h, which is not included in the binary download, and building
> apr 1.3.2 was broken with errors in that file (apr_arch_misc.h).
>
> Thanks for doing the tcnative release.
>
> Detailed Comments
> =================
>
> Signature of Tarball is OK.
>
> Changelog looks a little strange, because it ends at 1_1.12 (or 1_1.13, but
> there's no headline for that version).
>
> README.txt:
>
> It says "This directory contains both the native and java-side code for
> Tomcat Native Library.". But in fact there is only the jni directory
> included. So also the other comments about ant and about test examples are
> not applicable.
>
> Instead of "To build the native part see native/BUILDING" maybe we should
> use the path jni/native/BUILDING.
>
> File BUILDING:
>
> Before talking about buildconf, it might first list the usual procedure
> (configure, make, make install).
>
> There is a block
>
> ===
>  Build the jar containing the example by
>  cd ..
>  ant jar
>  Run the example:
>  ant example-basic
> ===
>
> which doesn't apply, because no build.xml and no examples and JavaFiles are
> included in the tarball.
>
> The NOTE: "configure --without-ssl : Configure without ssl support." is
> unclear, because there is also a --disable-openssl.
>
> configure:
>
> --enable-openssl and --disable-openssl both disable OpenSSl
>
> You should apply the following patch to configure.in:
>
> ===
> % diff -u configure.in.orig configure.in before the next release
> --- configure.in.orig   2007-09-20 22:36:05.000000000 +0200
> +++ configure.in        2008-07-01 22:23:55.000000000 +0200
> @@ -141,10 +141,14 @@
>  use_openssl=true;
>
>  AC_ARG_ENABLE(openssl,
> -[ --disable-openssl   avoid using OpenSSL toolkit],
> +[AS_HELP_STRING([--disable-openssl],[avoid using OpenSSL toolkit])],
>  [
> -  use_openssl=false;
> -  AC_MSG_RESULT([Disabling SSL support...])
> +  case "${enableval}" in
> +    no )
> +        use_openssl=false;
> +        AC_MSG_RESULT([Disabling SSL support...])
> +        ;;
> +  esac
>  ])
>
>  if $use_openssl ; then
> ===
>
> The recreated configure then behaves as wanted (disables disables, enable
> enables (default) and enable-openssl=no disables).
>
> configure seems not to be in sync with configure.in. If I recreate it, one
> message chánges:
>
> % diff configure.orig configure
> 1257,1258c1257,1258
> <   --with-apr=PATH         prefix for installed APR, path to APR build
> tree,
> <                           or the full path to apr-config
> ---
>>   --with-apr=PATH         prefix for installed APR or the full path to
>>                              apr-config
>
>
> Compile warnings:
>
> src/poll.c: In function 'Java_org_apache_tomcat_jni_Poll_poll':
> src/poll.c:284: warning: 'now' may be used uninitialized in this function
>
> src/ssl.c: In function 'ssl_rand_make':
> src/ssl.c:364: warning: value computed is not used
>
> src/network.c: In function 'Java_org_apache_tomcat_jni_Socket_sendv':
> src/network.c:667: warning: pointer targets in assignment differ in
> signedness
> src/network.c:673: warning: pointer targets in passing argument 3 of
> '(*e)->ReleaseByteArrayElements' differ in signedness
> src/network.c: In function 'Java_org_apache_tomcat_jni_Socket_sendfile':
> src/network.c:1217: warning: pointer targets in assignment differ in
> signedness
> src/network.c:1222: warning: pointer targets in assignment differ in
> signedness
> src/network.c:1240: warning: pointer targets in passing argument 3 of
> '(*e)->ReleaseByteArrayElements' differ in signedness
> src/network.c:1244: warning: pointer targets in passing argument 3 of
> '(*e)->ReleaseByteArrayElements' differ in signedness
>
> src/file.c: In function 'Java_org_apache_tomcat_jni_File_writev':
> src/file.c:384: warning: pointer targets in assignment differ in signedness
> src/file.c:390: warning: pointer targets in passing argument 3 of
> '(*e)->ReleaseByteArrayElements' differ in signedness
> src/file.c: In function 'Java_org_apache_tomcat_jni_File_writevFull':
> src/file.c:418: warning: pointer targets in assignment differ in signedness
> src/file.c:428: warning: pointer targets in passing argument 3 of
> '(*e)->ReleaseByteArrayElements' differ in signedness
>
> Regards,
>
> Rainer
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message