tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: C code needs review
Date Mon, 07 Jul 2008 06:23:49 GMT
Mark Thomas wrote:
> I've just attached a couple of patches to 
> https://issues.apache.org/bugzilla/show_bug.cgi?id=43327
> 
> One of the patches is a patch to native and since all I know just about 
> know enough C to be dangerous, I would be grateful if someone who 
> actually knows what they are doing when it comes to C could review it.
> 

Patch makes sense, but at the first look it's not
very well implemented. Think we could skip the conversion
of compile time APR_* flags to our flag translation.
Also, some socket implementations allows IPV4 bind on
IPV6 socket, so it might be usable only when there is
custom configuration that doesn't permit IPV4 bound
IPV6 addresses. In standard case it might even break the
things.

I'll take a more deeper look at it this week.

Cheers
-- 
^(TM)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message