tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yo...@apache.org
Subject svn commit: r681087 - /tomcat/current/tc5.5.x/STATUS.txt
Date Wed, 30 Jul 2008 15:46:57 GMT
Author: yoavs
Date: Wed Jul 30 08:46:57 2008
New Revision: 681087

URL: http://svn.apache.org/viewvc?rev=681087&view=rev
Log:
Reviewed Tomcat 5.5 patches and added my comments in status.txt

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=681087&r1=681086&r2=681087&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul 30 08:46:57 2008
@@ -30,21 +30,22 @@
   http://svn.apache.org/viewvc?rev=616953&view=rev (less the generics stuff)
   +1: markt, fhanik
   -1:
+  0: yoavs (because I think there might be a bug when we're only diong the work if log.isTraceEnabled)
 
 * Fix ArrayIndexOutOfBoundsException when empty URL is requested
   http://svn.apache.org/viewvc?rev=627883&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44562
   http://svn.apache.org/viewvc?rev=635294&view=rev (prior code clean up)
   http://svn.apache.org/viewvc?rev=635297&view=rev (the actual fix)
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * Fix docs re use of maxActive
   http://svn.apache.org/viewvc?rev=639842&view=rev
-  +1: rjung, markt, fhanik
+  +1: rjung, markt, fhanik, yoavs
   -1:
 
 * Port fix for regression in 5.5.26 (and 4.1.37) that limited uploads to 8k
@@ -56,18 +57,18 @@
 * Fix ServletInputStream still readable when closed
   https://issues.apache.org/bugzilla/show_bug.cgi?id=44673
   http://svn.apache.org/viewvc?rev=641076&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * Fix CGI servlet for vista
   http://people.apache.org/~markt/patches/2008-03-28-cgi-env.patch
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * No roles (deny all) trumps no auth-constraint (allow all)
   https://issues.apache.org/bugzilla/show_bug.cgi?id=44529
   http://svn.apache.org/viewvc?rev=642542&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * Fix reading of multi-byte request data
@@ -83,7 +84,7 @@
 * Document missing secret attributes
   https://issues.apache.org/bugzilla/show_bug.cgi?id=44715
   http://svn.apache.org/viewvc?rev=643497&view=rev
-  +1: mark, fhanik
+  +1: mark, fhanik,yoavs
   -1:
 
 * Final fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=44494
@@ -93,23 +94,23 @@
   http://svn.apache.org/viewvc?rev=645719&view=rev (Remy's resizing fix)
   http://svn.apache.org/viewvc?rev=645722&view=rev (mark/reset fix)
   +1: markt
-  -1: fhanik - trunk patches wont work in 5.5, rainer has a backport, I'll review those
+  -1: fhanik - trunk patches won't work in 5.5, rainer has a backport, I'll review those
 
 * Better handling of lack of permission for context specific logging
   http://svn.apache.org/viewvc?rev=646543&view=rev
   +1: markt
-   0: fhanik - silently swallow an error, and default to the default config file
+   0: fhanik - silently swallow an error, and default to the default config file, yoavs:
don't like silent swallowing
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45293
   Additional permission required to read JDK logging config
   http://svn.apache.org/viewvc?rev=646550&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * Change of jar name for policy file
   http://people.apache.org/~markt/patches/2008-04-09-policy.patch
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * Another fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=44494
@@ -129,45 +130,45 @@
   Create digesters and parsers earlier so we aren't using the webapp class
   loader when we create them.
   http://svn.apache.org/viewvc?rev=649974&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=31257
   Quote endorsed dirs if they contain a space
   http://svn.apache.org/viewvc?rev=649993&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43578
   http://svn.apache.org/viewvc?rev=651713&view=rev
   Tomcat doesn't start if installation path contains a space
   Patch provided by Ray Sauers
-  +1: markt
+  +1: markt, yoavs
   -1: 
 
 * Log errors for AJP signoffs at DEBUG level, since it is harmless if mod_jk has hung up
the phone.
   http://svn.apache.org/viewvc?rev=651792&view=rev
-  +1: billbarker, markt, fhanik
+  +1: billbarker, markt, fhanik, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44877
   Prevent collisions in tag pool names
   http://svn.apache.org/viewvc?rev=651984&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43191
-  No way to turn off compression for some miime-types
+  No way to turn off compression for some MIME types
   Based on a patch by Len Popp
   http://svn.apache.org/viewvc?rev=653032&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43117
   Setting an empty workDir can delete all of CATALINA_HOME
   Patch provided by Takayuki Kaneko.
   http://svn.apache.org/viewvc?rev=653113&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43079
@@ -176,7 +177,7 @@
   Move odd url-pattern warning to StandardContext so a) we catch all patterns
   and b) it isn't logged to the wrong webapp
   Based on a patch by John Kew
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44021
@@ -184,41 +185,41 @@
   Add support for # to signify multi-level contexts for directories and
   wars.
   http://svn.apache.org/viewvc?rev=653549&view=rev
-  +1: markt
+  +1: markt, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44943
   Reduce issues caused by copy/paste and different engine names
   http://svn.apache.org/viewvc?rev=654177&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42943
   Make sure nested element is inside <jsp:text> element before throwing
   exception.
   http://svn.apache.org/viewvc?rev=654640&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42899
   When saving config from admin app, correctly handle case where old config file
   does not exist.
   http://people.apache.org/~markt/patches/2008-05-10-bug42899.patch
-  +1: markt
+  +1: markt, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
   You can't use an unescaped quote if you quote the value with that character
   http://svn.apache.org/viewvc?rev=657231&view=rev
   http://svn.apache.org/viewvc?rev=670074&view=rev
-  +1: markt
+  +1: markt, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42750
   Make parsing of request line more tolerant of multiple SP and/or HT
   Note: This is on the critical path
   http://svn.apache.org/viewvc?rev=657954&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45195
@@ -226,24 +227,24 @@
   is a regression from 5.0.x Also avoid NPE on remove
   http://svn.apache.org/viewvc?rev=667604&view=rev
   http://svn.apache.org/viewvc?rev=668854&view=rev
-  +1: markt
+  +1: markt, yoavs
   -1: 
 
 * Remove the JDK 1.3 references from SSL How To
   http://people.apache.org/~markt/patches/2008-06-21-SSL-docs.patch
-  +1: markt
+  +1: markt, yoavs
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42727
   Correctly handle request lines that are exact multiples of 4096 in length.
   Patch provided by Will Pugh.
   http://svn.apache.org/viewvc?rev=677759&view=rev
-  +1: markt
+  +1: markt, yoavs
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45453
   Add required sync to race condition
   Based on a patch by Santtu Hyrkk
   http://svn.apache.org/viewvc?rev=680725&view=rev
-  +1: markt
+  +1: markt, yoavs
   -1: 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message