tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r668249 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Date Tue, 17 Jun 2008 17:27:57 GMT

Filip Hanik - Dev Lists wrote:
> 
> my initial reaction is a -1 to this one
> 
> it should be
> 
> if ( entry != null && entry.isPrimary() ) set.add(new 
> MapEntry(key,entry.getValue()));
> 
> and not propagate internals of the cluster information out to the caller

Fine by me. I'll try and do this later tonight but if you get there first 
feel free.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message