tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 45272] Version 1 cookie not persisted in IE
Date Wed, 25 Jun 2008 21:15:15 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=45272





--- Comment #6 from Filip Hanik <fhanik@apache.org>  2008-06-25 14:15:14 PST ---
One potential fix is to treat the path value for quoting as v0 

Index: java/org/apache/tomcat/util/http/ServerCookie.java
===================================================================
--- java/org/apache/tomcat/util/http/ServerCookie.java  (revision 671643)
+++ java/org/apache/tomcat/util/http/ServerCookie.java  (working copy)
@@ -299,7 +299,7 @@
         // Path=path
         if (path!=null) {
             buf.append ("; Path=");
-            maybeQuote2(version, buf, path);
+            maybeQuote2(0, buf, path);
         }

         // Secure

and that will only quote the path if it contains :; or a space

however, this again, opens up the wormhole of 
setPath("/=somepath==");

and would break, potentially, the javax.servlet.http.Cookie.setPath should do a
check

will come back


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message