Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of costin@gmail.com designates
 72.14.220.158 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:to:subject:mime-version:content-type;
        b=S4Ejc6Gw1Trb5LO8dAGssNxJKq+t5IpEcaxMG3EgjhyejWUiSYX9CkBpjpAvdp6S2DxFNyCzgVf0F4wvQA6vR1pE4/1qmVJYToYleLpGIujuc69oe1okHvKD0+9kyTtPyhJoCneoBqnlXBhlbSD/Q09mbqc7ZkU3JcCehpS1deo=
Message-ID: <96e4b5230805042031t1dc62230pb91ff20977d7b415@mail.gmail.com>
Date: Sun, 4 May 2008 20:31:21 -0700
From: "Costin Manolache" <costin@gmail.com>
Reply-To: costin@apache.org
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Subject: JConsole and tomcat.
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_19341_22325175.1209958281258"

------=_Part_19341_22325175.1209958281258
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

This is a proposal for a very small change in tomcat trunk, to make tomcat
easier to use with JConsole.
Right now if you start tomcat 'out of box' and than try to inspect it with
jconsole, you'll only see the 'platform' mbeans
(memory etc). That's because tomcat doesn't use the platform mbean server.

The fix is simple - in main or anywhere before the first
MBeanServerFactory.findMBeanServer(null) we need
to add a ManagementFactory.getPlatformMBeanServer(). This way modeler and
tomcat will find the platform
mbean server as the first server and use it. A better fix would be to
replace all usages of findMBeanServer with
getPlatformMBeanServer.

The options are:
- add a flag/system property to enable this behavior

- make it default, add a flag to disable and use separate server

- just use getPlatformMBeanServer with no flag.

The javadoc is:

  " It is recommended that this platform MBeanServer also be used
    to register other application managed beans  besides the platform
MXBeans.
   This will allow all MBeans to be published through the same
    MBeanServer and hence allow for easier network publishing
    and discovery."


I can't think of any good reason to use a separate MBean server - and using
jconsole is quite nice, all
other methods of remote JMX documented on our site are more complex ( but
good for specific cases ).
The extra benefit is that we can see both memory/logging/other platform
mbeans in the same place with
tomcat beans.

Options ? Can I just add the one liner before the first invocation of
MBeanServerFactory ?


Costin

------=_Part_19341_22325175.1209958281258--