Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <48200860.6080008@apache.org>
Date: Tue, 06 May 2008 08:27:28 +0100
From: Mark Thomas <markt@apache.org>
User-Agent: Thunderbird 2.0.0.12 (Windows/20080213)
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Generics and the spec interfaces
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

All,

As you have probably noticed I am doing some clean-up of the trunk codebase 
as and when the opportunity arises. So far the clean has identified the odd 
copy/paste error or casting problem as well as (hopefully) making the code 
easier to read. The fixes for the errors are getting ported to 6.0.x.

I am currently pondering what to do with lines like this:
Enumeration e = request.getHeaderNames();

As I see it the options are:
1. Leave it as it is.
2. Use
Enumeration<?> e = request.getHeaderNames();
3. Use
Enumeration<String> e = request.getHeaderNames();
4. Use
Enumeration<String> e = request.getHeaderNames();
and modify HttpServletRequest to use generics
5. Something else.

I am leaning towards 4 on the basis that
a) This is trunk, not a release branch
b) This option generates no warnings
c) I assume the spec will start using generics at some point (maybe in 3.0?)
If modifying the spec interfaces seems like a step too far then 3 would be 
my next choice.

Thoughts?

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org