tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: Potential problem with COMET & sendfile
Date Wed, 21 May 2008 21:08:52 GMT
I don't see any use case for Comet+sendfile make sense.

but if you do it, you should

...
set your sendfile stuff
call CometEvent.close()
.....

ie, the event shouldn't be cometized when doing sendfile, it makes zero 
sense since when the file is sent, the HTTP request is over.

Filip

Alex Barclay wrote:
> Remy Maucherat wrote:
>> On Tue, 2008-05-20 at 15:40 -0700, Alex Barclay wrote:
>>  
>>> This works fine in the small. Here's what I'm seeing inside the 
>>> tomcat code. I was clued into this by not being able to find my 
>>> socket (being kept alive) because all of the pollers were on a 
>>> "wait" call, rather than on a "poll" call.
>>>     
>>
>> No need to write a novel to expose a simple problem. BTW, Comet +
>> sendfile is not tested at all, so it is possible it won't work right.
>> The issue you're seeing is that at the end of sendfile it does a
>> processSocket(state.socket) rather than add back to the poller (which is
>> the normal procedure at the end of processing many other requests).
>>
>>   
> It's getting tested now ;-)
>
> I've found a couple of bugs so far. I'll have patches by the end of 
> the week.
>
> In our application we're using this for our main file server, sending 
> files up to 10MB in length, so this is showing up lots of interesting 
> behavior.
>
> Alex.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message