Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 15020 invoked from network); 8 Apr 2008 23:23:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Apr 2008 23:23:31 -0000 Received: (qmail 59079 invoked by uid 500); 8 Apr 2008 23:23:28 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 59019 invoked by uid 500); 8 Apr 2008 23:23:28 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 59006 invoked by uid 99); 8 Apr 2008 23:23:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Apr 2008 16:23:28 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [72.22.94.67] (HELO virtual.halosg.com) (72.22.94.67) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Apr 2008 23:22:45 +0000 Received: (qmail 11496 invoked from network); 8 Apr 2008 18:11:31 -0500 Received: from unknown (HELO ?62.12.11.25?) (62.12.11.25) by halosg.com with SMTP; 8 Apr 2008 18:11:31 -0500 Message-ID: <47FBFE5F.2060506@hanik.com> Date: Wed, 09 Apr 2008 01:23:11 +0200 From: Filip Hanik - Dev Lists User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java References: <20080407224757.82F8A1A9832@eris.apache.org> In-Reply-To: <20080407224757.82F8A1A9832@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org ignore my prev email about the mem leak, I wasn't up to current in trunk, and was running into something else Filip markt@apache.org wrote: > Author: markt > Date: Mon Apr 7 15:47:54 2008 > New Revision: 645722 > > URL: http://svn.apache.org/viewvc?rev=645722&view=rev > Log: > All of the issues I was seeing with mark/reset were due to states that resulted in a call to CharChunk.flushBuffer(). > I tried many different ways to fix it but by far the simplest was this patch that just increases the size of the CharChunk internal buffer when creating the mark sufficiently that flushBuffer() is never called. > With this patch I can't break mark/reset with bug 44494's test case in single or multibyte mode. > > Modified: > tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java > > Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java > URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java?rev=645722&r1=645721&r2=645722&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java (original) > +++ tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java Mon Apr 7 15:47:54 2008 > @@ -457,11 +457,7 @@ > cb.setOffset(0); > } > } > - int offset = readAheadLimit; > - if (offset < size) { > - offset = size; > - } > - cb.setLimit(cb.getStart() + offset); > + cb.setLimit(cb.getStart() + readAheadLimit + size); > markPos = cb.getStart(); > } > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org