Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 91995 invoked from network); 27 Apr 2008 17:20:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Apr 2008 17:20:18 -0000 Received: (qmail 80412 invoked by uid 500); 27 Apr 2008 17:20:13 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 80346 invoked by uid 500); 27 Apr 2008 17:20:13 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 80332 invoked by uid 500); 27 Apr 2008 17:20:13 -0000 Delivered-To: apmail-jakarta-tomcat-dev@jakarta.apache.org Received: (qmail 80327 invoked by uid 99); 27 Apr 2008 17:20:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Apr 2008 10:20:13 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Apr 2008 17:19:37 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id E96031A981C; Sun, 27 Apr 2008 10:19:50 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r651984 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Date: Sun, 27 Apr 2008 17:19:50 -0000 To: tomcat-dev@jakarta.apache.org From: markt@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080427171950.E96031A981C@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: markt Date: Sun Apr 27 10:19:48 2008 New Revision: 651984 URL: http://svn.apache.org/viewvc?rev=651984&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44877 Prevent collisions in tag pool names Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=651984&r1=651983&r2=651984&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original) +++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Sun Apr 27 10:19:48 2008 @@ -294,6 +294,9 @@ attrNames[i] = attrs.getQName(i); } Arrays.sort(attrNames, Collections.reverseOrder()); + if (attrNames.length > 0) { + poolName = poolName + "&"; + } for (int i = 0; i < attrNames.length; i++) { poolName = poolName + "_" + attrNames[i]; } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org