From dev-return-88375-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Fri Apr 04 14:49:40 2008 Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 59980 invoked from network); 4 Apr 2008 14:49:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Apr 2008 14:49:39 -0000 Received: (qmail 42911 invoked by uid 500); 4 Apr 2008 14:49:36 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 42879 invoked by uid 500); 4 Apr 2008 14:49:36 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 42868 invoked by uid 500); 4 Apr 2008 14:49:36 -0000 Delivered-To: apmail-jakarta-tomcat-dev@jakarta.apache.org Received: (qmail 42865 invoked by uid 99); 4 Apr 2008 14:49:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Apr 2008 07:49:36 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Apr 2008 14:49:03 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id 4EBA4234C0B9; Fri, 4 Apr 2008 07:47:03 -0700 (PDT) From: bugzilla@apache.org To: tomcat-dev@jakarta.apache.org Subject: DO NOT REPLY [Bug 38483] access log valve uses simpledateformat in tread-unsafe way X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Tomcat 5 X-Bugzilla-Component: Catalina X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: niallp@apache.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: tomcat-dev@jakarta.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <20080404144703.4EBA4234C0B9@brutus.apache.org> Date: Fri, 4 Apr 2008 07:47:03 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=38483 --- Comment #12 from Niall Pemberton 2008-04-04 07:47:02 PST --- I don't see that theres a problem any more - the block that uses most (i.e. all except fileDateFormatter) of the SimpleDateFormats is now in a synchronized block: synchronized (this) { if (currentDate != date) { StringBuffer current = new StringBuffer(32); current.append('['); current.append(dayFormatter.format(date)); // Day current.append('/'); current.append(lookup(monthFormatter.format(date))); // Month current.append('/'); current.append(yearFormatter.format(date)); // Year current.append(':'); current.append(timeFormatter.format(date)); // Time current.append(' '); current.append(getTimeZone(date)); // Timezone current.append(']'); currentDateString = current.toString(); currentDate = date; } } ...and fileDateFormatter is used in the rotate() method which is also synchronized Looks to me like this was resolved in the following revision: http://svn.apache.org/viewvc?view=rev&revision=494191 But perhaps I'm looking at the wrong version - as code I see differs from what Peter quotes (StringBuffer is called current rather than result) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org