tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r646121 - /tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c
Date Wed, 09 Apr 2008 12:45:27 GMT
markt@apache.org schrieb:
> --- tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c (original)
> +++ tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c Tue Apr  8 15:52:49 2008
> @@ -49,7 +49,7 @@
>  
>  #include <strsafe.h>
>  
> -#define VERSION_STRING "Jakarta/ISAPI/" JK_VERSTRING
> +#define VERSION_STRING "Jakarta/ISAPI/" JK_EXPOSED_VERSION
>  #define SHM_DEF_NAME   "JKISAPISHMEM"
>  #define DEFAULT_WORKER_NAME ("ajp13")
>  
> @@ -1799,9 +1799,7 @@
>          }
>      }
>      if (rc) {
> -        jk_log(logger, JK_LOG_INFO,
> -               "isapi_redirect/%s initialized",
> -               JK_VERSTRING);
> +        jk_log(logger, JK_LOG_INFO, "Initialized %s", (VERSION_STRING) );

I would prefer to keep the init messages for mod_jk/isapi/nsapi more 
consistent. So adding "-dev" etc. is fine, but before we used 
"mod_jk/something initialized", "isapi_redirect/something initialized", 
"nsapi_redirector/something initialized".

Guess I'm going to define PACKAGE in iis and nsapi appropriately, s.t. 
JK_EXPOSED_VERSION automatically contains the correct plugin name and we 
can switch back to a uniform log format. I'll have a look later today.

>      }
>      return rc;
>  }

Thanks for applying the patch nevertheless :)

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message